linux-kernel - Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200205101126.4fad0946@endymion>
Date:   Wed, 5 Feb 2020 10:11:26 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Huacai Chen <chenhc@...ote.com>,
        Xuefeng Li <lixuefeng@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yinglu Yang <yangyinglu@...ngson.cn>
Subject: Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information

On Wed, 05 Feb 2020 10:55:38 +0800, Jiaxun Yang wrote:
> > I think it is better to split it into the following two patches?
> > [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
> > [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)  
> 
> That way will break bisect.

Are you sure? As far as I can see, each patch builds individually. The
dmi patch is a no-op alone. The mips patch will not work alone,
obviously, however according to Tiezhu dmi_scan_machine() will fail
with a harmless error message if the base address is 0xF0000. If that's
correct then it's not breaking bisect.

-- 
Jean Delvare
SUSE L3 Support