linux-kernel - Re: [PATCH -next] ACPI: debug: Make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 09 May 2020 11:35:22 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Zheng Zengkai <zhengzengkai@...wei.com>
Cc:     lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ACPI: debug: Make two functions static

On Thursday, May 7, 2020 9:07:36 AM CEST Zheng Zengkai wrote:
> Fix sparse warnings:
> 
> drivers/acpi/acpi_dbg.c:748:12: warning:
>  symbol 'acpi_aml_init' was not declared. Should it be static?
> drivers/acpi/acpi_dbg.c:774:13: warning:
>  symbol 'acpi_aml_exit' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@...wei.com>
> ---
>  drivers/acpi/acpi_dbg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c
> index 7a265c2171c0..6041974c7627 100644
> --- a/drivers/acpi/acpi_dbg.c
> +++ b/drivers/acpi/acpi_dbg.c
> @@ -745,7 +745,7 @@ static const struct acpi_debugger_ops acpi_aml_debugger = {
>  	.notify_command_complete = acpi_aml_notify_command_complete,
>  };
>  
> -int __init acpi_aml_init(void)
> +static int __init acpi_aml_init(void)
>  {
>  	int ret;
>  
> @@ -771,7 +771,7 @@ int __init acpi_aml_init(void)
>  	return 0;
>  }
>  
> -void __exit acpi_aml_exit(void)
> +static void __exit acpi_aml_exit(void)
>  {
>  	if (acpi_aml_initialized) {
>  		acpi_unregister_debugger(&acpi_aml_debugger);
> 

Applied as 5.8 material, thanks!