linux-kernel - Re: [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z98av2cbURhSy6Rk@kernel.org>
Date: Sat, 22 Mar 2025 22:17:03 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Borislav Petkov <bp@...en8.de>
Cc: Stefano Garzarella <sgarzare@...hat.com>,
	Tom Lendacky <thomas.lendacky@....com>,
	Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-integrity@...r.kernel.org, Dov Murik <dovmurik@...ux.ibm.com>,
	Dionna Glaze <dionnaglaze@...gle.com>, linux-coco@...ts.linux.dev,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Claudio Carvalho <cclaudio@...ux.ibm.com>,
	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH v3 1/4] x86/sev: add SVSM vTPM probe/send_command
 functions

On Fri, Mar 21, 2025 at 11:05:20PM +0100, Borislav Petkov wrote:
> On Fri, Mar 21, 2025 at 10:01:17AM +0100, Stefano Garzarella wrote:
> > Just a note, patch 2 adds `include/linux/svsm_vtpm.h`, that file is
> > basically a translation of the AMD SVSM specification into structures and
> > functions used to communicate with SVSM in the way it is defined by the
> > specification.
> > 
> > I realized that the file does not fall under any section of MAINTAINERS.
> > How do you suggest we proceed?
> > 
> > Should we create an SVSM section to maintain it, including the TPM driver
> > and future other drivers,etc.?
> 
> This all belongs to the TPM drivers, right?
> 
> I.e., drivers/char/tpm/
> 
> So I guess add that header to the TPM DEVICE DRIVER section if the gents there
> are fine with it...

It's fine for me but I'd suggest to rename the header as "tpm_svsm.h".
Then this will already provide coverage:

https://web.git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a2fbcecc7027944a2ce447d4dd72725c5822321f


> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
> 

BR, Jarkko