linux-kernel - Re: [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Add mux-states property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2080db04-9845-4193-8dd9-7bb84894815b@kernel.org>
Date: Sun, 30 Nov 2025 09:22:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Josua Mayer <josua@...id-run.com>, Ulf Hansson <ulf.hansson@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Magnus Damm <magnus.damm@...il.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Mikhail Anikin <mikhail.anikin@...id-run.com>,
 Yazan Shhady <yazan.shhady@...id-run.com>, Jon Nettleton
 <jon@...id-run.com>, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mmc: renesas,sdhi: Add mux-states
 property

On 28/11/2025 17:15, Josua Mayer wrote:
> Add mux controller support for when sdio lines are muxed between a host
> and multiple cards.
> 
> There are several devices supporting a choice of eMMC or SD on a single
> board by both dip switch and gpio, e.g. Renesas RZ/G2L SMARC SoM and
> SolidRun RZ/G2L SoM.
> 
> In-tree dts for the Renesas boards currently rely on preprocessor macros
> to hog gpios and define the card.
> 
> By adding mux-states property to sdio controller description, boards can
> correctly describe the mux that already exists in hardware - and drivers
> can coordinate between mux selection and probing for cards.
> 
> Signed-off-by: Josua Mayer <josua@...id-run.com>
> ---
>  Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index c754ea71f51f7..55635c60ad73a 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -106,6 +106,11 @@ properties:
>    iommus:
>      maxItems: 1
>  
> +  mux-states:
> +    description:
> +      mux controller node to route the SDIO signals from SoC to cards.
> +    maxItems: 1
> +
>    power-domains:
>      maxItems: 1
>  
> @@ -262,9 +267,17 @@ unevaluatedProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/r8a7790-cpg-mssr.h>
> +    #include <dt-bindings/gpio/gpio.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
>      #include <dt-bindings/power/r8a7790-sysc.h>
>  
> +    mux: mux-controller {
> +            compatible = "gpio-mux";
> +            #mux-state-cells = <1>;
> +            mux-gpios = <&pinctrl RZG2L_GPIO(22, 1) GPIO_ACTIVE_LOW>;


Wrong indentation and not really relevant here, so just drop.

Best regards,
Krzysztof