netdev - Re: [PATCH net-next] r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533d7dbc-f17a-d9fd-e9c8-0a2452f4c899@gmail.com>
Date:   Wed, 21 Feb 2018 07:29:24 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: remove not needed PHY soft reset in
 rtl8168e_2_hw_phy_config

Am 21.02.2018 um 05:27 schrieb David Miller:
> From: Heiner Kallweit <hkallweit1@...il.com>
> Date: Tue, 20 Feb 2018 07:30:16 +0100
> 
>> rtl8169_init_phy() resets the PHY anyway after applying the chip-specific
>> PHY configuration. So we don't need to soft-reset the PHY as part of the
>> chip-specific configuration.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> I'm not so comfortable with this.
> 
> There are so many r8169 chip variants out there.
> 
> And who knows, maybe one of them needs this second PHY reset or due to
> some way the driver is coded it is necessary.
> 
> Unless you can test this change on every r8169 chip type, I'm very
> reluctant to apply this patch.
> 
I understand the concern, the change however is in rtl8168e_2_hw_phy_config()
which is specific to chip version 34 (RTL8168evl).
On my system with this chip version the change didn't change system behavior.


> Sorry.
>